sdks/python/scripts: support pytest user markers#35655
sdks/python/scripts: support pytest user markers#35655damccorm merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
apache_beam.testing.util.BeamAssertException: Failed assert: ['a'] == ['a', 'b'], unexpected elements ['b'] [while running 'assert_that/Match']
The failures of this CI workflow beam_PreCommit_Python_Coverage are unrelated to the change set this PR introduce
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Sorry - missed this! It LGTM, thank you!
I will let checks complete before merging
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
2 participants
Description
This change set allow us to pass user-defined pytest markers.
Towards #35598.
Towards #35577.
Related https://lists.apache.org/thread/d1dkpsfl5yj8p1mod4oscj1m846yo64b.
Motivation and Context
It implements @damccorm's proposed solution #35598 (comment)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.UpdateCHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.